Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate initialisation message codes in NetCDFRead #185

Open
sadielbartholomew opened this issue May 18, 2022 · 0 comments
Open

Duplicate initialisation message codes in NetCDFRead #185

sadielbartholomew opened this issue May 18, 2022 · 0 comments
Labels
netCDF read Relating to reading netCDF datasets question Further information is requested

Comments

@sadielbartholomew
Copy link
Member

sadielbartholomew commented May 18, 2022

Whilst improving some docstrings in #183 I noticed that there were two cases where duplicate integer values were provided as codes in the _code0 dictionary, namely duplication on 200 and 201 with:

"Bounds variable": 200,
"bounds attribute": 201,

and

"Tie points coordinate variable": 200,
"Bounds tie points variable": 201,

where for all other keys in that dictionary, and indeed in the similar dict _code1, the values are unique numbers. Possibly this wasn't noticed before due to the ordering of the key-value pairs, which are ordered with the values strictly increasing except for the former pair of bounds-related cases which were out-of-place.

@davidhassell is this an issue or is there a reason for the duplication? Thanks.

@sadielbartholomew sadielbartholomew added the question Further information is requested label May 18, 2022
@sadielbartholomew sadielbartholomew changed the title Duplicate field-initialisation message codes in NetCDFRead Duplicate initialisation message codes in NetCDFRead May 18, 2022
@davidhassell davidhassell added the netCDF read Relating to reading netCDF datasets label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
netCDF read Relating to reading netCDF datasets question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants