Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-term fix for errors in reading of metadata-only CDL #129

Merged

Conversation

sadielbartholomew
Copy link
Member

@sadielbartholomew sadielbartholomew commented Mar 26, 2021

Fixes #128

@sadielbartholomew sadielbartholomew self-assigned this Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #129 (1bc2e73) into master (b2b3d55) will decrease coverage by 0.01%.
The diff coverage is 85.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   88.67%   88.66%   -0.00%     
==========================================
  Files         101      101              
  Lines        9948     9954       +6     
==========================================
+ Hits         8820     8825       +5     
- Misses       1128     1129       +1     
Flag Coverage Δ
unittests 88.66% <85.72%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cfdm/read_write/read.py 87.50% <85.72%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b3d55...1bc2e73. Read the comment docs.

@sadielbartholomew
Copy link
Member Author

Fair point from Codecov, it would certainly be good to have an extra test to cover metadata-only CDL and potential errors arising from reading it in, ensuring they are handled okay. I'll add one to this PR next week, so hold on merging.

@sadielbartholomew
Copy link
Member Author

The new commit adds testing to cover the cases of relevance. Opening and closing to re-trigger the CI tests...

@sadielbartholomew
Copy link
Member Author

The Codecov 'patch' change is sufficient but not the 'project' change, though having looked through the details I am satisfied the latter case is not an issue in context.

All the other tests pass both on the CI and locally, so this is ready to merge.

@sadielbartholomew sadielbartholomew merged commit db7789b into NCAS-CMS:master Mar 29, 2021
@sadielbartholomew sadielbartholomew deleted the i197-cdl-read-maskerror branch March 29, 2021 22:58
@davidhassell davidhassell added this to the 1.8.9.0 milestone May 10, 2021
@davidhassell davidhassell added the netCDF read Relating to reading netCDF datasets label Nov 15, 2023
@davidhassell davidhassell linked an issue Nov 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
netCDF read Relating to reading netCDF datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping of metadata-only CDL to field constructs
2 participants