Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the radius determination for the field mask #146

Open
2 tasks done
detoma opened this issue Jan 29, 2024 · 6 comments
Open
2 tasks done

Improve the radius determination for the field mask #146

detoma opened this issue Jan 29, 2024 · 6 comments
Assignees
Labels
bug Fix for existing functionality of the pipeline needs testing Draft done, testing needed to complete

Comments

@detoma
Copy link
Contributor

detoma commented Jan 29, 2024

In 2012 (and likely in 2011) the field mask and occulter were not always co-centered.

Our centering routine does not find a reliable center for field mask and this introduced artifact in the data and must be improved before reprocessing 2011. We also need to reprocess some 2012 days when the center was incorrect.

This may be caused by the initial center guess that is based on a first simple estimate of the occulter center. I would start by increasing the range for the inflection point search for the file mask to see if finds the center better.

We can also try changing the fixed 250 threshold as described in issue #145

To further debug this and issue #132, I would like to run intermediate products for 2012 05 17.

Tasks

  • put initial guess for occulter/field radii in epochs file and use when finding center of flat
  • reprocess 20120517 with intermediate product ({fg,bkg}{plus, minus})
@detoma detoma added the bug Fix for existing functionality of the pipeline label Jan 29, 2024
@detoma detoma added this to the Decommissioning reprocessing milestone Jan 29, 2024
@detoma
Copy link
Contributor Author

detoma commented Jan 31, 2024

The radius-guess for the field mask should change before and after 2012 Dec 9, because the plate scale changed from 4.46 arcsec/pixel to 4.35 arcsec/pixel. The values should be stored in the epoch file.

The code use a field radius guess to find the circle in the flats, then the values in the flat is used as guess for the science images. The old values used in the code for after 2012 was 297 but checking several random files, it seems the values of the field radius is always slightly larger, i.e. ~300 pixels, so I am changing this to a higher number

The radius guess for the field stop should be:

  • after 20121209: 299
  • before 20121209: 292

@mgalloy
Copy link
Member

mgalloy commented Feb 2, 2024

Processing 20120517 with intermediate products has started. Results will appear on process.intermediate and should be completed by Saturday morning if all goes well (there are a lot of untested changes in the current pipeline).

@mgalloy
Copy link
Member

mgalloy commented Feb 6, 2024

The intermediate products are in engineering.intermediate/2012/05/17 with names like 20120517.143132.comp.pre-combine.p0.w0.sav.

@detoma
Copy link
Contributor Author

detoma commented Feb 6, 2024

I looked at the four images (on and off band for the two beams) before they are combined. They look misaligned, so it is not the beam combination nor the continuum subtraction that causes the problem. I attach an example

Screenshot 2024-02-06 at 3 37 32 PM

Changing the flat center guess did not help. Images look even worse than during the original 2012 processing.

@detoma
Copy link
Contributor Author

detoma commented Feb 6, 2024

The raw data look fine and aligned.

The problem is the flat. It is not finding the right center for two flats early in the day. This is one of the flat in the engineering directory. The centering is totally off.

Screenshot 2024-02-06 at 4 14 32 PM

@detoma
Copy link
Contributor Author

detoma commented Feb 6, 2024

The new guesses for the occulter radius and field stop radius chosen for the epoch before 2012 12 09 work well.

We need to improve the threshold for the first guess of the center. I hope this will fix the issue. I modified it to:

threshold = 10*median(flat-dark)

@mgalloy mgalloy added the needs testing Draft done, testing needed to complete label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix for existing functionality of the pipeline needs testing Draft done, testing needed to complete
Projects
None yet
Development

No branches or pull requests

2 participants