Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNTSLoader] Unsupported features with custom points material #594

Open
Desplandis opened this issue Jun 28, 2024 · 1 comment
Open

[PNTSLoader] Unsupported features with custom points material #594

Desplandis opened this issue Jun 28, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Desplandis
Copy link

Hi!

We are currently utilizing the 3d-tiles-renderer with a custom points material which could support both NORMAL/NORMAL_OCT16P per-point feature (as a standard normal attribute), and BATCH_LENGTH global feature.

I understand that the default PointsMaterial in three does not currently support normal attributes. However, I would like to propose adding support for loading NORMAL/NORMAL_OCT16P, in line with three semantics.

Moreover, I suspect that since BATCH_LENGTH as no equivalent in the default PointsMaterial, we'll have to assign it later when using our custom points material. However, could we at least disable the warnings to not flood the console?

Before submitting a PR, I would appreciate your feedback on this proposal. =)

@Desplandis Desplandis added the enhancement New feature or request label Jun 28, 2024
@gkjohnson gkjohnson added this to the v0.3.36 milestone Jun 29, 2024
@gkjohnson
Copy link
Contributor

Hello! If you'd like to implement a PR to add support for the NORMAL and NORMAL_OCT16P feature flags for PNTSLoader that would be great. I don't want to add custom materials for lit points but we can definitely add a "normal" attribute to the points geometry and then you can replace the material with a custom lit one when loaded using the load-model event.

Regarding BATCH_LENGTH - I think that can be removed since it's read and used in the PNTSLoaderBase class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants