-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting discussion on future extension support? #185
Comments
I think being able to register an extension that uses certain predefined hooks to preprocess tiles like seems like a good design in the long run. It looks like GLTFLoader lets you register a full class that defines the hooks you'd need, but I'm not super familiar with the details of that code. For some of the more basic extensions I think it makes sense to just support them by default, though, which is probably the easier place to start. Were there any other extensions you were looking at using? What kinds of hooks would they wind up needing? For GLTF and GLB support I'd be okay with just adding those in the It probably also makes sense to start logging unsupported extensions so it's more clear what functionality is being skipped or might be broken when loading a tileset with an extension -- though I'm not sure how many of those are out in the wild yet. |
Hey @gkjohnson had you given this much more thought? We're looking at using the upcoming gltf extension |
Hi @Rennzie! #230 by @dbuck adds support for the It doesn't add support for the GLTF extension |
I went a little deeper on extensions today. In addition to the basic GLTF support in #230, I've got a first pass ExtensionSystem modeled very loosely after the GLTFParser plugin system. Test here: matterport#4 if you have some early thoughts @gkjohnson? - It's sitting on top of #230 + some other utilitarian changes so it's too messy for a direct PR as yet. |
Hey @gkjohnson, sorry for the delay (holidays and all). Our priorities have changed at the start of this year so I'm not going to be able to make an immediate start. Hopefully that changes but please don't wait. |
I added some basic plugin architecture in #603 that is heavily inspired by three.js' GLTFLoader plugin system. Basically you register a plugin and the TilesRenderer class can call a specific function on one or all registered plugins at different points during the tiles renderer update / load loop. We can continue to add new "hooks" as needed to support new plugins we want to provide in the future. |
I was checking out some of the recent changes in the
3d-tiles-next
branch here, and it brought up some thoughts about future extensibility.First item I was interested in the ability to just use GLTF as the content within tiles via 3DTILES_content_gltf
-> Replace the B3dm wrapper with gltf.
The text was updated successfully, but these errors were encountered: