Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: Separate Class and Context Manager #55

Closed
sanssecours opened this issue Feb 29, 2024 · 0 comments
Closed

Storage: Separate Class and Context Manager #55

sanssecours opened this issue Feb 29, 2024 · 0 comments
Labels
enhancement New feature or request usability Something does not work as assumed
Milestone

Comments

@sanssecours
Copy link
Member

Description

Some public methods of the class for storing HDF files (Storage) currently require that the HDF file represented by the object is open. This means you have to use the context manager of the class before you call these methods, which makes using the class incorrectly too easy. Ideally we should separate the context manager from the object that reads the file.

@sanssecours sanssecours added enhancement New feature or request usability Something does not work as assumed labels Feb 29, 2024
@sanssecours sanssecours added this to the 2.0.0 milestone Feb 29, 2024
sanssecours added a commit that referenced this issue Aug 28, 2024
This commit closes #55 and closes #56.
sanssecours added a commit that referenced this issue Sep 9, 2024
This commit closes #55 and closes #56.
@sanssecours sanssecours reopened this Sep 9, 2024
sanssecours added a commit that referenced this issue Sep 11, 2024
This commit closes #55 and closes #56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request usability Something does not work as assumed
Projects
None yet
Development

No branches or pull requests

1 participant