Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response code 204 (No Content) might want to not resolve the promise? #4

Open
zoobroker opened this issue Mar 23, 2018 · 0 comments
Open

Response code 204 (No Content) might want to not resolve the promise? #4

zoobroker opened this issue Mar 23, 2018 · 0 comments

Comments

@zoobroker
Copy link

if the underlying http call to msf.getData returns a 204, that seems like a place where we'd like to reject the promise so we can handle it in a catch rather than doing a null check ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zoobroker