Skip to content

Commit c6375b2

Browse files
MrGreensWorkshopMrGreensWorkshop
authored
Merge pull request #226 from MrGreensWorkshop/enhancements-for-page-load-performance2
Some of Accessible Rich Internet Applications (ARIA) attributes added for better accessibility.
2 parents d77e6de + 6ffc52c commit c6375b2

26 files changed

+45
-31
lines changed

‎_data/conf/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ top_nav_brand_text_enable: true
213213

214214
# set profile image
215215
# comment to disable the profile image
216-
side_nav_profile_img_path: /assets/img/posts/post_pic1.jpg
216+
side_nav_profile_img_path: /assets/img/default/profile_pic.jpg
217217

218218
# this adds hover effect to bottom buttons
219219
side_nav_bottom_buttons_hover_effect: "hover-effect"
@@ -300,7 +300,7 @@ meta:
300300
schema_markup_post_add_postbody: true
301301
schema_markup_logo_img: /assets/img/favicons/apple-touch-icon.png
302302
schema_markup_about_img: /assets/img/about/about.jpg
303-
schema_markup_default_meta_img: /assets/img/about/about.jpg
303+
schema_markup_default_meta_img: /assets/img/home/home-heading.jpg
304304
mobile_app: true
305305
android_mobile_app: true
306306
ios_mobile_app: true

‎_data/lang/en.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ no_translation_tooltip: No Translation
3434

3535
navigation:
3636
contact_header: Contact
37+
side_navigation_button: Side menu
38+
scroll_back_to_top: Back to top
3739

3840
color_scheme_switch_tooltip: Color scheme
3941

@@ -193,6 +195,7 @@ cookie_consent:
193195
accept: &accept_button Allow all
194196
settings: Customize
195197
deny: &deny_button Deny
198+
close: Close
196199
panel_settings:
197200
title: *cookie_settings
198201
msg: >

‎_data/lang/fr.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ no_translation_tooltip: Pas de traduction
3535

3636
navigation:
3737
contact_header: Contact
38+
side_navigation_button: Menu latéral
39+
scroll_back_to_top: Retour en haut
3840

3941
color_scheme_switch_tooltip: Schéma de couleur
4042

@@ -194,6 +196,7 @@ cookie_consent:
194196
accept: &accept_button Autoriser tout
195197
settings: Personnaliser
196198
deny: &deny_button Refuser
199+
close: Fermer
197200
panel_settings:
198201
title: *cookie_settings
199202
msg: >

‎_data/lang/ja.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ no_translation_tooltip: 訳がありません
3434

3535
navigation:
3636
contact_header: コンタクト
37+
side_navigation_button: サイドメニュー
38+
scroll_back_to_top: トップへ戻る
3739

3840
color_scheme_switch_tooltip: 配色
3941

@@ -106,7 +108,7 @@ post:
106108
telegram: Telegram
107109
linkedin: LinkedIn
108110
email: メール
109-
copy_link: リンクコピー
111+
copy_link: リンクをコピー
110112

111113
# for post-list layout
112114
post-list:
@@ -193,6 +195,7 @@ cookie_consent:
193195
accept: &accept_button 全て許可
194196
settings: 設定
195197
deny: &deny_button 拒否
198+
close: 閉じる
196199
panel_settings:
197200
title: *cookie_settings
198201
msg: >

‎_data/lang/pt.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ no_translation_tooltip: Não há tradução
3535

3636
navigation:
3737
contact_header: Contato
38+
side_navigation_button: Menu lateral
39+
scroll_back_to_top: Voltar ao topo
3840

3941
color_scheme_switch_tooltip: Escolha a cor
4042

@@ -194,6 +196,7 @@ cookie_consent:
194196
accept: &accept_button Aceitar
195197
settings: Configurações
196198
deny: &deny_button Negar
199+
close: Fechar
197200
panel_settings:
198201
title: *cookie_settings
199202
msg: >

‎_includes/default/cookie-consent-bar.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
{%- assign info_text = info_text | append : privacy_text -%}
1717

1818
<div class="consent-bar">
19-
<a class="close-button" href="javascript:void(0);" onclick="CookieConsent.hideConsentBar();"><i class="fa-fw fa fa-times"></i></a>
19+
<a class="close-button" href="javascript:void(0);" onclick="CookieConsent.hideConsentBar();" aria-label="{{ data_conf.buttons.close }}" role="button" rel="nofollow"><i class="fa-fw fa fa-times"></i></a>
2020
<p>{{ info_text }}</p>
2121
{%- assign items = site.data.conf.main.cookie_consent.bar_buttons %}
2222
{%- for index in (1..items.size) %}
@@ -29,7 +29,7 @@
2929
{%- unless forloop.last %}{%- assign arguments = arguments | append: " " -%} {% endunless -%}
3030
{%-endfor%}
3131
{%-if index == item[1][0] %}
32-
<a href="javascript:void(0);" class="btn-base {{ arguments }}" onclick="CookieConsent.consentBarDone('{{ name }}');" role="button">{{ data_conf.buttons[name] }}</a>
32+
<a href="javascript:void(0);" class="btn-base {{ arguments }}" onclick="CookieConsent.consentBarDone('{{ name }}');" role="button" rel="nofollow">{{ data_conf.buttons[name] }}</a>
3333
{%-endif-%}
3434
{%-endfor%}
3535
{%-endfor%}

‎_includes/default/cookie-consent-settings.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ <h5>{{ data_conf.title }}</h5>
6666
{%- unless forloop.last %}{%- assign arguments = arguments | append: " " -%} {% endunless -%}
6767
{%-endfor%}
6868
{%-if index == item[1][0] %}
69-
<a href="javascript:void(0);" class="btn-base {{ arguments }}" onclick="CookieConsent.consentSettingDone('{{ name }}');" role="button">{{ data_conf.buttons[name] }}</a>
69+
<a href="javascript:void(0);" class="btn-base {{ arguments }}" onclick="CookieConsent.consentSettingDone('{{ name }}');" role="button" rel="nofollow">{{ data_conf.buttons[name] }}</a>
7070
{%-endif-%}
7171
{%-endfor%}
7272
{%-endfor%}

‎_includes/default/nav/contact-links.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ <h3>{{ site.data.lang[lng].navigation.contact_header }}</h3>
2020
{%- assign contact_icon_tag = nil -%}
2121
{%- assign icon_first_chr = contact_const.icon | slice: 0 -%}
2222
{%- if contact_const.icon contains 'http://' or contact_const.icon contains 'https://' or icon_first_chr == '/' %}
23-
{%- capture contact_icon_tag -%} <img src="{{ contact_const.icon }}" /> {%- endcapture %}
23+
{%- capture contact_icon_tag -%} <img src="{{ contact_const.icon }}" alt="{{ account_key }}"/> {%- endcapture %}
2424
{% else %}
2525
{%- capture contact_icon_tag -%} <i class="{{ contact_const.icon }}" aria-hidden="true"></i> {%- endcapture %}
2626
{% endif -%}
2727
<li>
2828
{%- if account_key == 'email' -%}
2929
{%- assign _email = account_username | split: '@' %}
30-
<a href="javascript:void(0);" {{ effect_contacts_button }} onclick="setAddress('{{ _email[0] }}', '{{ _email[1] }}');">{{ contact_icon_tag }}</a>
30+
<a href="javascript:void(0);" aria-label="{{ account_key }}" {{ effect_contacts_button }} onclick="setAddress('{{ _email[0] }}', '{{ _email[1] }}');">{{ contact_icon_tag }}</a>
3131
{%- else -%}
3232
{%- assign mastodon_rel_tag_attr_value = nil -%}
3333
{%- if account_key == 'mastodon' and site.data.conf.main.contacts_mastodon_link_verification == true -%}
@@ -45,7 +45,7 @@ <h3>{{ site.data.lang[lng].navigation.contact_header }}</h3>
4545
{%- endif -%}
4646

4747
{%- assign tag_url = contact_const.url | append:'/' | append: account_username -%}
48-
<a href="{{ tag_url }}" {{ effect_contacts_button }} {{ contact_new_tab_tag_attr }} {{ contact_rel_tag_attr }}>{{ contact_icon_tag }}</a>
48+
<a href="{{ tag_url }}" aria-label="{{ account_key }}" {{ effect_contacts_button }} {{ contact_new_tab_tag_attr }} {{ contact_rel_tag_attr }}>{{ contact_icon_tag }}</a>
4949
{%- endif -%}
5050
</li>
5151
{%- endfor -%}

‎_includes/default/nav/lang-switch.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
{%- endfor -%}
5151
{%- if lng_set_flg == nil -%}
5252
<li>
53-
<a href="javascript:void(0);" class="{{ site.data.conf.main.language_switch_hover_effect }}" onclick="showToolTip(this, '{{ site.data.lang[tmp_lng].no_translation_tooltip }}');" data-toggle="tooltip" data-placement="bottom" title="">
53+
<a href="javascript:void(0);" role="button" class="{{ site.data.conf.main.language_switch_hover_effect }}" onclick="showToolTip(this, '{{ site.data.lang[tmp_lng].no_translation_tooltip }}');" data-toggle="tooltip" data-placement="bottom" title="">
5454
{{ site.data.lang[tmp_lng].lng.switch_title }}&nbsp;</a>
5555
</li>
5656
{%- endif -%}

‎_includes/default/nav/navigation-side-nav.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
</div>
2525
<br>
2626
{% if site.data.conf.main.side_nav_toggle_button_no_top_nav_buttons and site.data.conf.main.side_nav_toggle_close_button -%}
27-
<a href="javascript:void(0);" class="side-nav-close">
27+
<a href="javascript:void(0);" class="side-nav-close" role="button" rel="nofollow">
2828
<i class="fa fa-angle-double-left fa-2x" aria-hidden="true"></i>
2929
</a>
3030
{% endif -%}

0 commit comments

Comments
 (0)