Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input localization #29

Open
nickmaio opened this issue May 23, 2024 · 2 comments
Open

Search input localization #29

nickmaio opened this issue May 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nickmaio
Copy link

Is there a chance to be able to replace search input placeholder text with a localized version?

PS. Awesome package, thanks!

@MrBartusek MrBartusek added the enhancement New feature or request label May 23, 2024
@MrBartusek
Copy link
Owner

I think it would actually be a great idea to implement a localization system overall since things like #28 will just make a need for more strings.

However I am not sure what would be a best practice here for implementing, I don't see many packages ship localisation.

@nickmaio
Copy link
Author

nickmaio commented May 24, 2024

Localization on the Tenor level is pretty much 100% when you set both props country and locale correctly, no further work is required here. All that's hardcoded in 'en-EN' right now is the search input placeholder. A tiny inconvenience that may rather be resolved by exposing a single prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants