Let loadExtension return success status

Author: aboks

src/WrappedConnection.php

@@ -2,6 +2,11 @@
 namespace Moxio\SQLiteExtendedAPI;
 
 final class WrappedConnection {
+    /* From https://github.com/sqlite/sqlite/blob/278b0517d88d4150830a4ee2c628a55da40d186d/src/sqlite.h.in#L421 */
+    private const SQLITE_OK = 0;
+    /* From https://github.com/sqlite/sqlite/blob/278b0517d88d4150830a4ee2c628a55da40d186d/src/sqlite.h.in#L423 */
+    private const SQLITE_ERROR = 1;
+
     /* From https://github.com/sqlite/sqlite/blob/278b0517d88d4150830a4ee2c628a55da40d186d/src/sqlite.h.in#L2330 */
     private const SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION = 1005;
 
@@ -17,8 +22,10 @@ public function getDatabaseFilename(): string {
         return $this->sqlite3_ffi->sqlite3_db_filename($this->sqlite3_pointer, "main");
     }
 
-    public function loadExtension(string $shared_library): void {
+    public function loadExtension(string $shared_library): bool {
         $this->sqlite3_ffi->sqlite3_db_config($this->sqlite3_pointer, self::SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION, 1, null);
-        $this->sqlite3_ffi->sqlite3_load_extension($this->sqlite3_pointer, $shared_library, null, null);
+        $result_code = $this->sqlite3_ffi->sqlite3_load_extension($this->sqlite3_pointer, $shared_library, null, null);
+
+        return $result_code === self::SQLITE_OK;
     }
 }

test/Integration/ExtensionLoadingTest.php

@@ -24,7 +24,14 @@ public function testLoadExtensionLoadsAnSQLiteExtension() {
             $this->markTestSkipped(sprintf("SQLite extension file '%s' needed for test not found", self::EXTENSION));
         }
 
-        $this->wrapped_connection->loadExtension(self::EXTENSION);
+        $this->assertTrue($this->wrapped_connection->loadExtension(self::EXTENSION));
         $this->assertNotFalse($this->pdo->query(self::EXTENSION_VERIFICATION_QUERY));
     }
+
+    public function testLoadExtensionReturnsFalseIfExtensionCouldNotBeLoaded() {
+        $extension_dir = ini_get('sqlite3.extension_dir') ?: '/usr/lib/x86_64-linux-gnu';
+        $extension_file = $extension_dir . '/mod_does_not_exist.so';
+
+        $this->assertFalse($this->wrapped_connection->loadExtension($extension_file));
+    }
 }