From 66a660a43a08c06ca296a14178806f6ca8ad5ae1 Mon Sep 17 00:00:00 2001
From: Tobias Nett <skaldarnar@googlemail.com>
Date: Sun, 13 Jun 2021 12:32:49 +0200
Subject: [PATCH] checkstyle: adjust rules HiddenField, LineLength,
 InnerTypeLast, RegexpSingleLine (#17)

* remove regex rules for "Created with/by"
* reduce max line length to 150
* lower severity of HiddenField to INFO
* lower severity of InnerTypeLast to INFO
---
 checkstyle/checkstyle.xml | 26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)

diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml
index dea88c6..ab9a2d1 100644
--- a/checkstyle/checkstyle.xml
+++ b/checkstyle/checkstyle.xml
@@ -9,7 +9,7 @@
     <!-- ************************** -->
     <module name="LineLength">
         <property name="severity" value="warning"/>
-        <property name="max" value="175"/>
+        <property name="max" value="150"/>
     </module>
 
     <module name="SuppressionFilter">
@@ -44,21 +44,11 @@
     </module>
   
     <!-- Disallow author names and auto-generated tags -->
-    <!-- TODO: replace with proper JavaDoc checks as soon as they work properly. See checkstyle#952 -->
-    <module name="RegexpSingleline">
-        <property name="severity" value="warning"/>
-        <property name="format" value="Created with"/>
-        <property name="ignoreCase" value="true"/>
-        <property name="fileExtensions" value="java"/>
-        <property name="message" value="Auto-generated message 'Created With' is not allowed"/>
-    </module>
-    <module name="RegexpSingleline">
-        <property name="severity" value="warning"/>
-        <property name="format" value="Created by"/>
-        <property name="ignoreCase" value="true"/>
-        <property name="fileExtensions" value="java"/>
-        <property name="message" value="Auto-generated message 'Created By' is not allowed"/>
-    </module>
+    <!-- 
+        TODO: replace with proper JavaDoc checks as soon as they work properly.
+           See https://github.com/checkstyle/checkstyle/issues/952         
+           See https://github.com/checkstyle/checkstyle/issues/2506          
+    -->
     <module name="RegexpSingleline">
         <property name="severity" value="warning"/>
         <property name="format" value="^\s*\*\s*@author"/>
@@ -234,8 +224,10 @@
         <module name="EqualsHashCode"/>
         <!-- Checks that a local variable or a parameter does not shadow a field that is defined in the same class. -->
         <module name="HiddenField">
+            <property name="severity" value="info"/>
             <property name="ignoreConstructorParameter" value="true"/>
             <property name="ignoreSetter" value="true"/>
+            <property name="setterCanReturnItsClass" value="true"/>
         </module>
         <!-- Checks for assignments in subexpressions. -->
         <module name="InnerAssignment"/>
@@ -305,7 +297,7 @@
         <module name="MutableException"/>
         <!-- Check nested (internal) classes/interfaces are declared at the bottom of the class after all method and field declarations. -->
         <module name="InnerTypeLast">
-            <property name="severity" value="warning"/>
+            <property name="severity" value="info"/>
         </module>
 
         <!-- Miscellaneous other checks -->