Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeadlessClient instances should be registered to the engine's NetworkSystem (not just to the EntityManager) #19

Open
gianluca-nitti opened this issue Jun 22, 2018 · 0 comments

Comments

@gianluca-nitti
Copy link
Member

What the title says. Right now clients which connects via the HTTP/WebSocket service exposed by FacadeServer are registered to the engine's EntitySystem, so that they can run console commands - however, it would be better to register them to the NetworkSystem (which job is to keep track of all the connected clients).
This should allow ComponentSystems to receive event notifications (e.g. onConnected) related to headless clients, like they do for regular clients.
Besides improving the code structure (with NetworkSystem handling all kinds of clients, including "special" ones), right now an use case where this would improve usability is in the features intruduced in #17 (see this comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant