Skip to content

159 unit test astronomical calculations #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MosheBerman wants to merge 15 commits into
base: master
Choose a base branch
from
Open

159 unit test astronomical calculations #162

MosheBerman wants to merge 15 commits into from

Conversation

@MosheBerman
Copy link
Owner

@MosheBerman MosheBerman commented Dec 1, 2024

Adds automated tests to KosherCocoa.

Details

  • Defines aDynamicTests class. (It works by adding methods to the test class at runtime.)
  • Implement subclass to test NOAACalculatorTests.
    • Loads a CSV export of KosherJava's calendar generator
    • Iterates the dates in the CSV (Gregorian year 2023) for Lakewood NJ.
    • Calculates sunrise at elevation, seaLevelSunrise, sunset at elevation and seaLevelSunset.
    • Compares to the values in the CSV, with a 1 second margin of error.
    • To reduce runtime, the tests iterate with Swift's stride method, running the tests on every N days.

@MosheBerman
[Rename] KCAstronomicalCalculatorTests.swift to `KCNOAACalculatorTe…
def0725 
…sts.swift`.
@MosheBerman
Add file KCAstronomicalCalculatorTests.swift.
70cea51
@MosheBerman
Split testCalculatorNames between KCNOAACalculatorTests and `KCAs…
99e48eb 
…tronomicalCalculatorTests`.
@MosheBerman
Extract lakewood calculator to an instance variable.
7558493
@MosheBerman
Extract astronomical calendar to an instance variable.
3beee2e
@MosheBerman
Add file containing test cases for NOAA sunrise and sunset..
0d26ca8
@MosheBerman
Add code to read tests from file.
c119b95
@MosheBerman
Add code to 1) load test cases from CSV files. 2) Generate tests insi…
676a0bc 
…de the Obj-C runtime. 3) A bridging header for Swift-ObjC interop.
@MosheBerman
Delete code that was moved into CSV loader.
a463b4c
@MosheBerman
Add dynamic tests.
72f8cbe
@MosheBerman
Add test plan.
98f0ec1
@MosheBerman
Update how we validate output, allow for 1 second discrepancies in th…
634c942 
…e result.
@MosheBerman
Update test scheme.
1c27402
@MosheBerman MosheBerman linked an issue Dec 1, 2024 that may be closed by this pull request
Unit test astronomical calculations. #159
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arytbk arytbk Awaiting requested review from arytbk

@natanrolnik natanrolnik Awaiting requested review from natanrolnik

@isaac-friedman isaac-friedman Awaiting requested review from isaac-friedman

@fontebasso fontebasso Awaiting requested review from fontebasso

@jbemt48 jbemt48 Awaiting requested review from jbemt48

@sharshi sharshi Awaiting requested review from sharshi

@sousben sousben Awaiting requested review from sousben

@Gbeyda Gbeyda Awaiting requested review from Gbeyda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unit test astronomical calculations.

2 participants

@MosheBerman