fix(rstudio): Resolve container errors and improve env handling #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses several issues encountered when running the rstudio.sh script. The script would fail under two conditions: 1. If `conda` was not initialized, the `conda deactivate` command would error out. This has been removed as it's not essential for the script's operation. 2. The `apptainer exec` command was using an incorrect syntax for the `--env` flag, passing a comma-separated list instead of individual `key=value` pairs. This commit corrects the `--env` flag usage and introduces `--cleanenv` to ensure a predictable environment within the container. Additionally, the RStudio server would fail to start because it couldn't find the host user inside the container. This is resolved by bind-mounting the host's `/etc/passwd` and `/etc/group` files in read-only mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses several issues encountered when running the rstudio.sh script.
The script would fail under two conditions:
condawas not available, theconda deactivatecommand would raise a non-zero exit code. This has been removed as it's not essential for the script's operation any longer.apptainer execcommand was using an incorrect syntax for the--envflag, passing a comma-separated list instead of individualkey=valuepairs.This commit corrects the
--envflag usage and introduces--cleanenvto ensure a predictable environment within the container. Additional env vars, including RENV_PATHS_CACHE have been added.Additionally, in some cases the RStudio server would fail to start because it couldn't find the host user inside the container. This is resolved by bind-mounting the host's
/etc/passwdand/etc/groupfiles in read-only mode.Fixes #6