Skip to content

Commit 3609f36

Browse files
committed
[FLINK-10906][docker] Don't print configuration in docker-entrypoint.sh
In order to not leak secrets we should not print the configuration in docker-entrypoint.sh.
1 parent aabbd65 commit 3609f36

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

flink-container/docker/docker-entrypoint.sh

-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ if [ "${CMD}" == "--help" -o "${CMD}" == "-h" ]; then
3232
exit 0
3333
elif [ "${CMD}" == "${JOB_CLUSTER}" -o "${CMD}" == "${TASK_MANAGER}" ]; then
3434
echo "Starting the ${CMD}"
35-
echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
3635

3736
if [ "${CMD}" == "${TASK_MANAGER}" ]; then
3837
exec $FLINK_HOME/bin/taskmanager.sh start-foreground "$@"

flink-contrib/docker-flink/docker-entrypoint.sh

-2
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,13 @@ elif [ "$1" == "jobmanager" ]; then
2929
echo "Starting Job Manager"
3030
sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}/g" $FLINK_HOME/conf/flink-conf.yaml
3131

32-
echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
3332
exec $FLINK_HOME/bin/jobmanager.sh start-foreground
3433
elif [ "$1" == "taskmanager" ]; then
3534

3635
sed -i -e "s/jobmanager.rpc.address: localhost/jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}/g" $FLINK_HOME/conf/flink-conf.yaml
3736
sed -i -e "s/taskmanager.numberOfTaskSlots: 1/taskmanager.numberOfTaskSlots: $(grep -c ^processor /proc/cpuinfo)/g" $FLINK_HOME/conf/flink-conf.yaml
3837

3938
echo "Starting Task Manager"
40-
echo "config file: " && grep '^[^\n#]' $FLINK_HOME/conf/flink-conf.yaml
4139
exec $FLINK_HOME/bin/taskmanager.sh start-foreground
4240
fi
4341

0 commit comments

Comments
 (0)