Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on SPOT code in spot-2.x #83

Open
carolemieux opened this issue Mar 8, 2022 · 0 comments
Open

Remove dependency on SPOT code in spot-2.x #83

carolemieux opened this issue Mar 8, 2022 · 0 comments

Comments

@carolemieux
Copy link
Contributor

Issue #31 was solved in ed0f430, adding a version of Texada that supports SPOT-2.X.

Two key issues:

  • The code in ed0f430 includes code from SPOT, making that code GPL-3
  • SPOT-2.X removed the capacity to print formulas in native SPOT format, so there is a change to the output of Texada (G will be written as [], for instance)

Ideally, we should remove this dependency on code pulled from SPOT, either via:

  1. Refactoring the code in texada-src/src/formula to remove code pulled from SPOT. We should also update texada::ltl to remove all the types of formulas that are not supported by Texada (BunOp, AutomatOp, etc.)
  2. Entirely removing the SPOT dependency (i.e., building out own LTL parser).

In the end, 2. may be the better option. As far as I can tell the only real functional dependency on SPOT beyond parsing/printing is the negative_normal_form() function used in map_checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant