Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in JSON output #70

Open
bestchai opened this issue May 26, 2020 · 0 comments
Open

Fix bug in JSON output #70

bestchai opened this issue May 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bestchai
Copy link
Member

bestchai commented May 26, 2020

When working with Kartik on a use of Texada, it was revealed that I had introduced some bug in the JSON output. This should be fixed.

Update: problem is that we were using Kartik's unprocessed logs where event names can have double quotes inside them. The fix would probably be to make sure to escape double quotes inside event names. The bad event is

#!c++

elemFind : css selector : div.content > img[style*="opacity: 1"]

[Issue created by carolemieux: 2015-11-24]

[Comment created by bestchai: 2015-11-24]
In case you don't get to this soon, can you document the bug -- i.e., give input that leads to bad JSON output?

@bestchai bestchai added the bug Something isn't working label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant