You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Redesign front end on AngularJS, Bootstrap and jQuery.
Outstanding todos for this issue:
Clean-up server.go by using standard Go notation for ignoring return values (underscore _ return arg), adding comments throughout to properly document the logic, and improving error reporting (whenever an error is generated, it's string version should end up on the client-side).
Remove files from the old server implementation under www/
[Issue created by taaus: 2015-11-27]
[Last updated on bitbucket: 2016-01-14]
[Comment created by carolemieux: 2015-11-28]
Ok, just checking :)
[Comment created by taaus: 2015-11-28]
Yeah I know. I was having difficulties with branches so I recreated the same issue to change the issue number and went on to create a new branch with the new issue number. Sorry for the trouble!
[Comment created by carolemieux: 2015-11-27]
For future reference; if you want to edit something about an issue, you can use the edit command instead of creating a new one.
[Comment created by bestchai: 2016-01-14]
More comments on latest (revision f4b0c670a04c) in the Issue76 branch:
README file includes the line "Add a comment to this line" in
multiple places. I think the expectation is for you to fill in a bit
more details about the dependency -- why it is needed, and how the
installation proceeds. Doesn't have to be long, but this line has to
be replaced.
I made some updated to pushed server.go, make sure to pull/update.
I first re-formatted server.go -- there is a tool call gofmt that
you should use prior to pushing any code. My editor (emacs) runs it
by default whenever I save the file. You can set this up, or run it
manually or with scripts on the command line. This tool encodes the
de-factor formatting for Go code.
Current code in uploadMineHandler func creates numerous err
variables -- err2, err3, err4. You should have just one error that you
use (see code above).
Code in uploadMineHandler has some strange variables names, for
example fileB. What is that? You should give it a meaningful name.
Right now it is about as useful as "x". The other vars can also be
improved -- 'log' is actually 'logContent' and 'out' is actually
'openedFile' or 'tempFile', etc.
letterBytes is only used inside RandStringBytes. You should declare
it in that func. Limit scope to what you need, never more.
The text was updated successfully, but these errors were encountered:
Redesign front end on AngularJS, Bootstrap and jQuery.
Outstanding todos for this issue:
Clean-up server.go by using standard Go notation for ignoring return values (underscore _ return arg), adding comments throughout to properly document the logic, and improving error reporting (whenever an error is generated, it's string version should end up on the client-side).
Remove files from the old server implementation under www/
[Issue created by taaus: 2015-11-27]
[Last updated on bitbucket: 2016-01-14]
[Comment created by carolemieux: 2015-11-28]
Ok, just checking :)
[Comment created by taaus: 2015-11-28]
Yeah I know. I was having difficulties with branches so I recreated the same issue to change the issue number and went on to create a new branch with the new issue number. Sorry for the trouble!
[Comment created by carolemieux: 2015-11-27]
For future reference; if you want to edit something about an issue, you can use the edit command instead of creating a new one.
[Comment created by bestchai: 2016-01-14]
More comments on latest (revision f4b0c670a04c) in the Issue76 branch:
README file includes the line "Add a comment to this line" in
multiple places. I think the expectation is for you to fill in a bit
more details about the dependency -- why it is needed, and how the
installation proceeds. Doesn't have to be long, but this line has to
be replaced.
I made some updated to pushed server.go, make sure to pull/update.
I first re-formatted server.go -- there is a tool call gofmt that
you should use prior to pushing any code. My editor (emacs) runs it
by default whenever I save the file. You can set this up, or run it
manually or with scripts on the command line. This tool encodes the
de-factor formatting for Go code.
Current code in uploadMineHandler func creates numerous err
variables -- err2, err3, err4. You should have just one error that you
use (see code above).
Code in uploadMineHandler has some strange variables names, for
example fileB. What is that? You should give it a meaningful name.
Right now it is about as useful as "x". The other vars can also be
improved -- 'log' is actually 'logContent' and 'out' is actually
'openedFile' or 'tempFile', etc.
letterBytes is only used inside RandStringBytes. You should declare
it in that func. Limit scope to what you need, never more.
The text was updated successfully, but these errors were encountered: