Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all models tutorial links to docstrings #110

Open
blondered opened this issue Feb 26, 2024 · 10 comments
Open

Add all models tutorial links to docstrings #110

blondered opened this issue Feb 26, 2024 · 10 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@blondered
Copy link
Collaborator

blondered commented Feb 26, 2024

Feature Description

Extend models docstrings in the following way:

  1. Add short description of the algorithm if necessary (examples of such short descriptions can be found in our README)
  2. Add description to scores. For example, for ALS model it could be something like: Model scores are dot products of learnt user embedding and recommended item embeddings for user-to-item recommendations. For item-to-item recommendations scores are cosine similarities between target item embedding and recommended item embeddings.

Why this feature?

Helpful for new users

Additional context

No response

@blondered blondered added documentation Improvements or additions to documentation good first issue Good for newcomers labels Feb 26, 2024
@blondered blondered moved this to 📋 Backlog in RecTools board Feb 26, 2024
@Saloni0512
Copy link

Hi, I would like to work on this issue, if it's still incomplete.

@blondered
Copy link
Collaborator Author

Hello! Sure, thanks.
I've extended description of this issue.
You can start from one model and open a draft PR with it. This way we can make sure that the form is right. And then you can continue to do descriptions to all of the models.

@Saloni0512
Copy link

Okay sure!

@Saloni0512
Copy link

Hi, I wanted to ask that in which file I am supposed to add the model scores . In the docs folder, there is a models.rst file and model_selection.rst file. Which one is supposed to have the required documentation.

@blondered
Copy link
Collaborator Author

Scores descriptions are supposed to be added to models docstrings in each module

@blondered
Copy link
Collaborator Author

I think, we are closing it since we are moving all this info to Extended Tutorial on RecSys Baselines. So it it now a duplicate

@blondered blondered closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in RecTools board May 14, 2024
@Saloni0512
Copy link

Okay sure, is there something else I can contribute to @blondered

@blondered
Copy link
Collaborator Author

If you still want the same kind of issue (contributing to documentation) you can add links from each model class docstring to this model in our "Extended baselines tutorial": https://rectools.readthedocs.io/en/latest/examples/tutorials/baselines_extended_tutorial.html
Correct links for each model can be found on this page: https://rectools.readthedocs.io/en/latest/tutorials.html

It this ok for you?

@Saloni0512
Copy link

Yeah sure but under which issue will I work then I mean this one is closed so. @blondered

@blondered
Copy link
Collaborator Author

Let's reopen it for this one for you.

@blondered blondered reopened this May 24, 2024
@blondered blondered moved this from ✅ Done to 📋 Backlog in RecTools board May 24, 2024
@blondered blondered changed the title Add all models scores descriptions to docstrings Add all models tutorial links to docstrings May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants