Skip to content

Commit 86aaac0

Browse files
committed
fix: truly remove S4325 violations in telemetry-integration.test.ts - 12 assertions
1 parent 020e355 commit 86aaac0

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

tests/server/telemetry-integration.test.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ describe("Telemetry - E2E Integration Pipeline", () => {
182182
let msg = server.getTelemetryMessage();
183183
client.receiveMessage(msg);
184184

185-
expect(client.getLastMetric()!.pinChangesPerSecond).toBe(5);
185+
expect(client.getLastMetric()?.pinChangesPerSecond).toBe(5);
186186

187187
// Second interval: 3 changes (starting fresh)
188188
server.recordPinChange();
@@ -192,27 +192,27 @@ describe("Telemetry - E2E Integration Pipeline", () => {
192192
msg = server.getTelemetryMessage();
193193
client.receiveMessage(msg);
194194

195-
expect(client.getLastMetric()!.pinChangesPerSecond).toBe(3);
195+
expect(client.getLastMetric()?.pinChangesPerSecond).toBe(3);
196196
});
197197

198198
it("should track debounce state correctly across reports", () => {
199199
// Record change to activate debounce
200200
server.recordPinChange();
201201
let msg = server.getTelemetryMessage();
202202
client.receiveMessage(msg);
203-
expect(client.getLastMetric()!.isThrottled).toBe(true);
203+
expect(client.getLastMetric()?.isThrottled).toBe(true);
204204

205205
// Immediately after, debounce still active
206206
msg = server.getTelemetryMessage();
207207
client.receiveMessage(msg);
208-
expect(client.getLastMetric()!.isThrottled).toBe(true);
208+
expect(client.getLastMetric()?.isThrottled).toBe(true);
209209

210210
// Wait for debounce to clear
211211
server.cleanup();
212212
server = new ServerTelemetrySimulator(); // Fresh instance
213213
msg = server.getTelemetryMessage();
214214
client.receiveMessage(msg);
215-
expect(client.getLastMetric()!.isThrottled).toBe(false);
215+
expect(client.getLastMetric()?.isThrottled).toBe(false);
216216
});
217217
});
218218

@@ -245,7 +245,7 @@ describe("Telemetry - E2E Integration Pipeline", () => {
245245
client.receiveMessage(msg);
246246

247247
// Verify
248-
expect(client.getLastMetric()!.serialOutputPerSecond).toBe(50);
248+
expect(client.getLastMetric()?.serialOutputPerSecond).toBe(50);
249249
});
250250

251251
it("should reset serial counter independently from pin counter", () => {
@@ -260,8 +260,8 @@ describe("Telemetry - E2E Integration Pipeline", () => {
260260
let msg = server.getTelemetryMessage();
261261
client.receiveMessage(msg);
262262

263-
expect(client.getLastMetric()!.pinChangesPerSecond).toBe(5);
264-
expect(client.getLastMetric()!.serialOutputPerSecond).toBe(10);
263+
expect(client.getLastMetric()?.pinChangesPerSecond).toBe(5);
264+
expect(client.getLastMetric()?.serialOutputPerSecond).toBe(10);
265265

266266
// Second interval: only pins (no serial)
267267
for (let i = 0; i < 3; i++) {
@@ -271,8 +271,8 @@ describe("Telemetry - E2E Integration Pipeline", () => {
271271
msg = server.getTelemetryMessage();
272272
client.receiveMessage(msg);
273273

274-
expect(client.getLastMetric()!.pinChangesPerSecond).toBe(3);
275-
expect(client.getLastMetric()!.serialOutputPerSecond).toBe(0);
274+
expect(client.getLastMetric()?.pinChangesPerSecond).toBe(3);
275+
expect(client.getLastMetric()?.serialOutputPerSecond).toBe(0);
276276
});
277277
});
278278

@@ -359,7 +359,7 @@ describe("Telemetry - E2E Integration Pipeline", () => {
359359
const msg = server.getTelemetryMessage();
360360
client.receiveMessage(msg);
361361

362-
expect(client.getLastMetric()!.pinChangesPerSecond).toBe(300);
362+
expect(client.getLastMetric()?.pinChangesPerSecond).toBe(300);
363363
});
364364

365365
it("should handle very high serial output rates", () => {
@@ -371,7 +371,7 @@ describe("Telemetry - E2E Integration Pipeline", () => {
371371
const msg = server.getTelemetryMessage();
372372
client.receiveMessage(msg);
373373

374-
expect(client.getLastMetric()!.serialOutputPerSecond).toBe(500);
374+
expect(client.getLastMetric()?.serialOutputPerSecond).toBe(500);
375375
});
376376

377377
it("should handle rapid alternating pin and serial events", () => {

0 commit comments

Comments
 (0)