Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor environment name by removing it from resource name and adding it as a tag instead #566

Open
eistrati opened this issue Jul 14, 2017 · 1 comment

Comments

@eistrati
Copy link
Contributor

In order to enable deepify to push different environments from one stage into another (e.g. stage push into prod, or prod to rollback into stage), we need to remove environment name (e.g. dev, test, stage, prod) from resource names (e.g. DeepDevLambdaExecution1234abcd, DeepStagePropertyRetrieve5678wxyz) and add instead tags for new environments or update tags for existing ones (e.g. DeepDevLambdaExecution1234abcd will become DeepLambdaExecution1234abcd with tag DeepEnvironment=dev, DeepStagePropertyRetrieve5678wxyz will become DeepPropertyRetrieve5678wxyz with tag DeepEnvironment=stage)

@mgoria
Copy link
Contributor

mgoria commented Jul 17, 2017

After analysing current resource naming implementation and other deep ecosystem related implementations I see some impediments here:

  1. Removing env name from resource name will result into naming collisions with other deployed apps.
  2. Not all services support Tagging.
  3. In order to enable deepify to push different environments from one stage into another we have to redeploy the app with parameters for this specific environment (e.g. In dev we use some stripe keys in prod we have different ones)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants