feat: Add linting for parameter objects

Author: Mitcheljager

app/assets/stylesheets/elements/_codemirror.scss

@@ -174,6 +174,11 @@
     background: transparent;
   }
 
+  .cm-lintRange-warning {
+    box-shadow: 0 3px 0 $orange;
+    background: transparent;
+  }
+
   .cm-lint-marker-error::before {
     content: "!";
     display: block;

app/javascript/src/lib/OWLanguageLinter.js

@@ -1,6 +1,7 @@
 import { getClosingBracket, getPhraseFromPosition, splitArgumentsString } from "../utils/parse"
 import { completionsMap, subroutinesMap, workshopConstants } from "../stores/editor"
 import { get } from "svelte/store"
+import { getFirstParameterObject } from "../utils/compiler/parameterObjects"
 
 let diagnostics = []
 
@@ -103,6 +104,7 @@ function findIncorrectArgsLength(content) {
       if (item.label != name) continue
 
       let message = ""
+      let severity = "error"
 
       if (item.args_unlimited) continue
 
@@ -126,22 +128,37 @@ function findIncorrectArgsLength(content) {
 
         const splitContent = splitArgumentsString(argumentsString)
 
-        if (item.args_min_length && splitContent.length >= item.args_min_length && splitContent.length <= item.args_length) break
-        if (!item.args_min_length && splitContent.length == item.args_length) break
+        // Arguments string is a parameter object
+        if (argumentsString.trim()[0] === "{") {
+          const parameterObject = getFirstParameterObject(content.slice(match.index, closing + 1))
 
-        const expectedString = `${ item.args_min_length ? "Atleast" : "" } ${ item.args_min_length || item.args_length }`
-        const maxString = `${ item.args_min_length ? ` (${ item.args_length } max)` : "" }`
-        const givenString = `${ splitContent.length } given`
+          if (!parameterObject) break
+
+          const invalidArgument = Object.keys(parameterObject.given).filter(i => i && !parameterObject.phraseParameters.includes(i))
+          if (invalidArgument?.length) {
+            message = `Argument(s) "${ invalidArgument.join(", ") }" are not valid for "${ name }"`
+            severity = "warning"
+          } else break
+        } else {
+          // Argument string is a regular list of arguments
+          if (item.args_min_length && splitContent.length >= item.args_min_length && splitContent.length <= item.args_length) break
+          if (!item.args_min_length && splitContent.length == item.args_length) break
+
+          const expectedString = `${ item.args_min_length ? "Atleast" : "" } ${ item.args_min_length || item.args_length }`
+          const maxString = `${ item.args_min_length ? ` (${ item.args_length } max)` : "" }`
+          const givenString = `${ splitContent.length } given`
+
+          message = `${ expectedString } Argument(s) expected${ maxString }, ${ givenString }`
+        }
 
-        message = `${ expectedString } Argument(s) expected${ maxString }, ${ givenString }`
       }
 
       if (!message) break
 
       diagnostics.push({
         from: match.index + match.match.length - name.length,
         to: match.index + match.match.length,
-        severity: "error",
+        severity,
         message: message
       })