Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Attachment Upload Progress #4

Open
2 tasks
astro opened this issue Mar 29, 2022 · 1 comment
Open
2 tasks

Tracking Attachment Upload Progress #4

astro opened this issue Mar 29, 2022 · 1 comment
Labels
enhancement New feature or request frontend low prio It's a valid to have this issue documented, but for now it's just a nice to have.

Comments

@astro
Copy link
Member

astro commented Mar 29, 2022

Für langsame Internetanbindung des Zielpublikums wäre Rückmeldung über den Upload-Fortschritt sinnvoll.

Aktuell geben wir fetch() ein FormData mit, welches einzelne Felder nicht aus ReadableStreams (wie von OpenPGP.js zurückgeliefert) laden kann.

2 Lösungsvorschläge:

  • Ersatz von FormData durch Code, um das Multipart-Formular stream-fähig zu bekommen. Welches npm-Modul? Selbst ein paar Strings aneinanderhängen?
  • Request Body ohne FormData direkt aus dem ReadableStream befüllen. Damit müssen alle anderen Felder in bspw. URI-Parameter ausgelagert werden.
@johannesloetzsch johannesloetzsch added enhancement New feature or request medium prio We want solve it in one of next sprints, but not before urgent tasks are done. frontend labels Mar 30, 2022
@johannesloetzsch
Copy link
Member

johannesloetzsch commented Mar 30, 2022 •
edited by astro
Loading

@astro I think in the first version it would be ok not to display the progress, but just:

  • indicate the upload was successful once HTTP 200 was returned from server
  • notify to the user when an upload failed
    • optional: automatic retry

@johannesloetzsch johannesloetzsch added low prio It's a valid to have this issue documented, but for now it's just a nice to have. and removed medium prio We want solve it in one of next sprints, but not before urgent tasks are done. labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request frontend low prio It's a valid to have this issue documented, but for now it's just a nice to have.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astro @johannesloetzsch