Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HuggingFace embeddings (i.e. HuggingFaceEmbedder) #216

Closed
brenkao opened this issue May 7, 2024 · 1 comment
Closed
Labels
Feature Request New feature or request

Comments

@brenkao
Copy link
Collaborator

brenkao commented May 7, 2024

Is your feature request related to a problem? Please describe.
Similar to HuggingFaceCall, you can already extend OpenAIEmbedder to use huggingface models.

class HuggingFaceEmbedder(OpenAIEmbedder):
    embedding_params = OpenAIEmbeddingParams(model="nomic-ai/nomic-embed-text-v1.5")
    api_key = "-"
    base_url = "http://localhost:8080"

but would be nice to have direct integration.

Describe the solution you'd like
An embedding interface similar to OpenAIEmbedder that extends BaseEmbedder, but with more direct integration with huggingface text-embeddings-inference.

Additional context
Here is the API reference.
https://huggingface.github.io/text-embeddings-inference/#/

@brenkao brenkao added Feature Request New feature or request good first issue Good for newcomers labels May 7, 2024
@willbakst willbakst changed the title Add new class HuggingFaceEmbedder Feature Request: Add support for HuggingFace embeddings May 8, 2024
@willbakst willbakst changed the title Feature Request: Add support for HuggingFace embeddings Feature Request: Add support for HuggingFace embeddings (i.e. HuggingFaceEmbedder) May 8, 2024
@willbakst willbakst changed the title Feature Request: Add support for HuggingFace embeddings (i.e. HuggingFaceEmbedder) [FEATURE REQUEST] Add support for HuggingFace embeddings (i.e. HuggingFaceEmbedder) May 8, 2024
@willbakst willbakst changed the title [FEATURE REQUEST] Add support for HuggingFace embeddings (i.e. HuggingFaceEmbedder) Add support for HuggingFace embeddings (i.e. HuggingFaceEmbedder) May 10, 2024
@willbakst willbakst removed the good first issue Good for newcomers label May 17, 2024
@willbakst
Copy link
Contributor

Similarly closing this issue as we have no current plans to take RAG out of beta (other than potentially something with Postgres, but uncertain).

If there's enough reason to build this, we can reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants