-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raygun4js only initialises if apiKey is set when onLoadHandler
is called
#454
Comments
We've come across this issue today and did some digging / reproduction on the issue. Please see this minimum reproduction and readme here: https://github.com/Codex-/rg4js-init-issue The issue is that in a lot of cases a key is configured for raygun after the library has initialised, to work around this a consumer can call I have a few ideas how this could be resolved but wanted to bounce ideas with the raygun team before I make a PR. Simplest thing would be to flag is Another would be a stepping retry as a floated promise. Let me know your thoughts :) |
Hey @Codex- , thanks for the reproduction and types PR! @Widdershin is currently away for a bit, but I've spoken to @darcythomas and we can take a look if you want to make a PR. The simplest approach seems fine for now 👍 |
No problem at all, I've raised #474 now with a fix :) Also, if you haven't seen it, I have also raised: DefinitelyTyped/DefinitelyTyped#61397 This is to add the missing typing for calling |
This makes it difficult to initialise
raygun4js
asynchronously, which is becoming more common.Related: #453, #383, #259
The text was updated successfully, but these errors were encountered: