Potential issue

[symbiogenesis]

I was looking at the analyzers around CA1507 and RCS1015 and I noticed the following code:

Dotmim.Sync/Projects/Dotmim.Sync.Core/Orchestrators/Commands/BaseOrchestrator.Commands.cs

Lines 185 to 189 in 63d56ef

	// Set the sync_row_timestamp
	// glitch in delete metadata command
	var syncSyncRowTimestamp = syncAdapter.GetParameter(context, command, "sync_row_timestamp");
	if (syncSyncRowTimestamp != null)
	syncAdapter.AddCommandParameterValue(context, syncSyncRowTimestamp, sync_min_timestamp.HasValue ? sync_min_timestamp.Value : DBNull.Value, command, commandType);

All of the other added command parameters in this function have matching variables to the string literal, and could actually be improved by converting them to use nameof().

Except this one.

On this one the string literal is "sync_row_timestamp" but there is no corresponding variable by that name, and the value being passed on line 189 is actually sync_min_timestamp

This has a comment about a glitch, so maybe it is intentional. Or, maybe this is why there is a glitch. I'm not sure.

[Mimetis]

Yes, this is just an historical mistake I've made in older versions that I still not fixed (coz it's working :) )
Will make a fix sooner or later :D