Cannot find the scope info client by using Client Id

[bearyung]

I am writing a web admin function for my data sync operations, and found that for the remoteOrchestrator.GetScopeInfoClientAsync(), if I just pass the cliend id (GUID) to the function, it will return me the null result, even if I pass the id and the scope name, it still returned me the null result.

        [HttpGet("scopeClients/{id:Guid}")]
        public async Task<JsonObject> GetScopeClientById(Guid id)
        {
            var connectionString = _configuration.GetConnectionString("DefaultConnection");
            var sqlProvider = new SqlSyncChangeTrackingProvider(connectionString);
            var remoteOrchestrator = new RemoteOrchestrator(sqlProvider);

            var resultScopeInfoClient = await remoteOrchestrator.GetScopeInfoClientAsync(id, "DefaultScope")
                .ConfigureAwait(false);

            if(resultScopeInfoClient != null)
            {
                return new JsonObject()
                {
                    { "id", resultScopeInfoClient.Id },
                    { "scopeName", resultScopeInfoClient.Name },
                    { "lastSync", resultScopeInfoClient.LastSync },
                    { "lastSyncDuration", resultScopeInfoClient.LastSyncDuration },
                    { "lastSyncTimestamp", resultScopeInfoClient.LastSyncTimestamp },
                    { "properties", resultScopeInfoClient.Properties },
                    { "parameters", resultScopeInfoClient.Parameters != null ? JsonSerializer.SerializeToNode(resultScopeInfoClient.Parameters) :null},
                    { "errors", resultScopeInfoClient.Errors}
                };
            }

            return new JsonObject();
        }

the GetScopeInfoClientAsync() only works if I provide the syncParameters along with the client id, scope name, like this:

        [HttpGet("scopeClients/{id:Guid}")]
        public async Task<JsonObject> GetScopeClientById(Guid id)
        {
            var connectionString = _configuration.GetConnectionString("DefaultConnection");
            var sqlProvider = new SqlSyncChangeTrackingProvider(connectionString);
            var remoteOrchestrator = new RemoteOrchestrator(sqlProvider);

            SyncParameters syncParameters = new SyncParameters();
            syncParameters.Add(new SyncParameter("AccountId", 8156));
            syncParameters.Add(new SyncParameter("ShopId", 1247));

            var resultScopeInfoClient = await remoteOrchestrator.GetScopeInfoClientAsync(id, "DefaultScope", syncParameters)
                .ConfigureAwait(false);

            if(resultScopeInfoClient != null)
            {
                return new JsonObject()
                {
                    { "id", resultScopeInfoClient.Id },
                    { "scopeName", resultScopeInfoClient.Name },
                    { "lastSync", resultScopeInfoClient.LastSync },
                    { "lastSyncDuration", resultScopeInfoClient.LastSyncDuration },
                    { "lastSyncTimestamp", resultScopeInfoClient.LastSyncTimestamp },
                    { "properties", resultScopeInfoClient.Properties },
                    { "parameters", resultScopeInfoClient.Parameters != null ? JsonSerializer.SerializeToNode(resultScopeInfoClient.Parameters) :null},
                    { "errors", resultScopeInfoClient.Errors}
                };
            }

            return new JsonObject();
        }

Would like to know if the only way to get the specific ScopeInfoClient is to get all the clients with GetAllScopeInfoClientsAsync() and then use the id to filter the list and get the fist matched result?

Thank you.

[Mimetis]

remoteOrchestrator.GetAllScopeInfoClientsAsync() is the best way to get all scopes and then you can filter them depending on your needs

[bearyung]

Thank you for the reply! Will keep using the remoteOrchestrator.GetAllScopeInfoClientsAsync() to serve the purpose now :)

And that will be great if I can get the specific scope_info_client by providing the guid as I have more than 5000 clients under the same scope, i am thinking a way not to get all clients every time when I want to just get one client's details 😆