Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apsect-ratio causing issues on old devices #8

Closed
MikhaD opened this issue Jan 24, 2022 · 13 comments
Closed

apsect-ratio causing issues on old devices #8

MikhaD opened this issue Jan 24, 2022 · 13 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MikhaD
Copy link
Owner

MikhaD commented Jan 24, 2022

The aspect ratio property is causing issues on old devices where it is not supported, see img

@MikhaD MikhaD added the bug Something isn't working label Jan 24, 2022
@MikhaD MikhaD self-assigned this Jan 24, 2022
@MikhaD MikhaD added the wontfix This will not be worked on label Feb 22, 2022
@JasonLovesDoggo
Copy link

It also happens on newer devices with odd aspect ratios.

Or if the page was zoomed out a lot.

@MikhaD
Copy link
Owner Author

MikhaD commented Feb 25, 2022

What do you mean with odd aspect ratio? This issue is here because of the limited support for the aspect-ratio CSS property which is not supported on older versions of certain browsers.

Could you give an example of what you mean?

@JasonLovesDoggo
Copy link

JasonLovesDoggo commented Feb 25, 2022

problem causes include:
Smaller resolutions
Extreme resolutions e.g. a much higher width then height and vice versa
And it becomes more extreme the lower the total resolution

( Tested on Chrome version 98.0.4758.102)

@MikhaD
Copy link
Owner Author

MikhaD commented Feb 26, 2022

Could you provide screenshots of the issues?

@JasonLovesDoggo
Copy link

Hey, sorry for the late response I was unavailable at the time

Images:
https://i.imgur.com/SGcp5YD.png
https://i.imgur.com/hULvvqW.png
https://i.imgur.com/TiJQidN.png

Not really that big of a problem as I don't know many devices that have aspect ratios like what's needed to replicate this bug
Also, I noticed that the answer boxes only scale when vertical changes happen not horizontal which leads to clipping

@MikhaD MikhaD removed the wontfix This will not be worked on label Jun 5, 2022
@MikhaD
Copy link
Owner Author

MikhaD commented Jun 5, 2022

Potentially fixable with margin-top aspect ratio hack and @supports(aspect-ratio: 1)

@JasonLovesDoggo
Copy link

Also are you working on a fix for #48

@MikhaD
Copy link
Owner Author

MikhaD commented Jun 9, 2022

Also are you working on a fix for #48

Unfortunately I don't have any apple devices, so I'm not sure how to debug #48 . I was kind of hoping that fixing this would fix that too. If you have any idea what is causing that it would be much appreciated.

@JasonLovesDoggo
Copy link

I have the exact same problem because I can't debug it either.
I believe it was caused by an iOS update
And possibility something to do with css grid

@JasonLovesDoggo
Copy link

That looks fine on my end

@JasonLovesDoggo
Copy link

Edit: here’s a front end resolution tool that shows the problem using the iPad Pro:

https://screenfly.org/#u=https%3A//mikhad.github.io/wordle/%23daily&w=1366&h=1024&a=22

Enter a word, problem is replicable. Very easy to debug from there. Cheers.

Screenshot_20220612-091747.png It works perfectly fine for me

@lukeswitz
Copy link

lukeswitz commented Jun 14, 2022

Grid gap set to 5 in the row and 5.5 in board. Solves issue on Apple devices with larger resolutions; Tested MBP 13,14,15" Monterey & iPad Pro iOS 15.5, addresses #48 & #49.

ssGrid

@MikhaD
Copy link
Owner Author

MikhaD commented Jan 8, 2023

consolidated into issue #61

@MikhaD MikhaD closed this as completed Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants