Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DirectoryPath type for passing path to aliases #69

Open
pascalberger opened this issue May 13, 2019 · 3 comments
Open

Use DirectoryPath type for passing path to aliases #69

pascalberger opened this issue May 13, 2019 · 3 comments

Comments

@pascalberger
Copy link
Contributor

The DockerBuild alias currently expects the path as a string. It would be more "Cake-like" if path parameter would be of type DirectoryPath.

Maybe there are also other places where DirectoryPath or FilePath can be used.

@MihaMarkic
Copy link
Owner

@pascalberger You are certainly correct. The thing was, that most of the settings were autogenerated from sources, where it isn't evident what string represents. Since then I dropped autogeneration (too fuzzy) and settings are manually added/changed.
So, yes, we can slowly replace them where it fits - it isn't a breaking change, right?

@pascalberger
Copy link
Contributor Author

It shouldn't be breaking as you still can pass a string afterwards

@MihaMarkic
Copy link
Owner

Good. I will keep in mind this, and if somebody provides PRs, I'll gladly merge them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants