Merge pull request #34 from eclipse439/master

Reezaali · web-flow · commit 6f0298bb0cd2 · 2022-06-24T09:02:37.000-07:00
Update Edge Extension Tutorials to use Manifest V3
diff --git a/extension-getting-started-part1/part1/manifest.json b/extension-getting-started-part1/part1/manifest.json
@@ -1,15 +1,15 @@
 {
   "name": "NASA Picture of the day viewer",
   "version": "0.0.0.1",
-  "manifest_version": 2,
+  "manifest_version": 3,
   "description": "A chromium extension to show NASA's Picture of the Day.",
   "icons": {
     "16": "icons/nasapod16x16.png",
     "32": "icons/nasapod32x32.png",
     "48": "icons/nasapod48x48.png",
     "128": "icons/nasapod128x128.png"
   },
-  "browser_action": {
+  "action": {
     "default_popup": "popup/popup.html"
   }
 }
diff --git a/extension-getting-started-part2/extension-getting-started-part2/manifest.json b/extension-getting-started-part2/extension-getting-started-part2/manifest.json
@@ -1,15 +1,15 @@
 {
   "name": "NASA Picture of the day viewer",
   "version": "0.0.0.1",
-  "manifest_version": 2,
+  "manifest_version": 3,
   "description": "A chromium extension to show NASA's Picture of the Day.",
   "icons": {
     "16": "icons/nasapod16x16.png",
     "32": "icons/nasapod32x32.png",
     "48": "icons/nasapod48x48.png",
     "128": "icons/nasapod128x128.png"
   },
-  "browser_action": {
+  "action": {
     "default_popup": "popup/popup.html"
   },
   "content_scripts": [
@@ -21,6 +21,9 @@
     }
   ],
   "web_accessible_resources": [
-    "images/*.jpeg"
+    {
+      "resources": ["images/*.jpeg"],
+      "matches": ["<all_urls>"]
+    }
   ]
 }
diff --git a/extension-getting-started-part2/extension-getting-started-part2/popup/popup.js b/extension-getting-started-part2/extension-getting-started-part2/popup/popup.js
@@ -5,7 +5,7 @@ if (sendMessageId) {
       chrome.tabs.sendMessage(
         tabs[0].id,
         {
-          url: chrome.extension.getURL("images/stars.jpeg"),
+          url: chrome.runtime.getURL("images/stars.jpeg"),
           imageDivId: `${guidGenerator()}`,
           tabId: tabs[0].id
         },

Original file line number	Diff line number	Diff line change
`@@ -1,15 +1,15 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "NASA Picture of the day viewer",`
`3`	`3`	`"version": "0.0.0.1",`
`4`		`- "manifest_version": 2,`
	`4`	`+ "manifest_version": 3,`
`5`	`5`	`"description": "A chromium extension to show NASA's Picture of the Day.",`
`6`	`6`	`"icons": {`
`7`	`7`	`"16": "icons/nasapod16x16.png",`
`8`	`8`	`"32": "icons/nasapod32x32.png",`
`9`	`9`	`"48": "icons/nasapod48x48.png",`
`10`	`10`	`"128": "icons/nasapod128x128.png"`
`11`	`11`	`},`
`12`		`- "browser_action": {`
	`12`	`+ "action": {`
`13`	`13`	`"default_popup": "popup/popup.html"`
`14`	`14`	`}`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ if (sendMessageId) {`
`5`	`5`	`chrome.tabs.sendMessage(`
`6`	`6`	`tabs[0].id,`
`7`	`7`	`{`
`8`		`- url: chrome.extension.getURL("images/stars.jpeg"),`
	`8`	`+ url: chrome.runtime.getURL("images/stars.jpeg"),`
`9`	`9`	imageDivId: `${guidGenerator()}`,
`10`	`10`	`tabId: tabs[0].id`
`11`	`11`	`},`