Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JSON Viewer is changing the JSON serialized value for some numbers #246

Closed
shawnwildermuth opened this issue Apr 10, 2024 · 6 comments
Closed
Labels
bug Something isn't working more info needed We need more information before we can act on this issue

Comments

@shawnwildermuth
Copy link

When using Edge for testing of an API, the JSON Viewer is changing the underlying JSON. See below:

image

I'd prefer to just turn off the view for now (since I am using extensions that do this, but they aren't enabled when the JSON Viewer is on).

@shawnwildermuth shawnwildermuth added the bug Something isn't working label Apr 10, 2024
@captainbrosset
Copy link
Contributor

Thanks for filing this issue. I'm having some difficulties reproducing the problem though. Here is what I tried:

  1. Open a new tab in Microsoft Edge.
  2. Enter the following URL in the address bar: data:text/json,[{"id": 1636, "price": 43.00}].
  3. Press Enter.

Here is the result:

image

I'm not seeing the change to {value: "43.00n", "type": "Big Number"} like you do.

@shawnwildermuth would you be able to provide a URL or JSON file for us to reproduce the issue?
Also, what's your Edge version?

In terms of disabling the JSON Viewer, you can do so by following these steps:

  1. Open a new tab and go to edge://flags
  2. In the search box at the top of the flags page, search for json viewer
  3. Change the flag to Disabled and then restart Edge.

image

@captainbrosset captainbrosset added the more info needed We need more information before we can act on this issue label Apr 11, 2024
@shawnwildermuth
Copy link
Author

So, I am seeing the same thing you are (because the JSON Viewer isn't being enabled for this query:

image

But when I go to an URL (instead of a data block or even a local file), the JSON Viewer is used:

image

When I open the edge://flags, I don't see a JSON Viewer.

image

I seem to have the latest version (though I am not using a preview of Windows):

image

@captainbrosset
Copy link
Contributor

On this screenshot:

image

the toolbar which you point to doesn't belong to the official Microsoft Edge JSON viewer. I don't know where it comes from, but it isn't our JSON viewer. Do you have an extension installed that handles JSON responses? I'm wondering if the Edge JSON viewer and a potential extension are competing to display JSON responses.

@shawnwildermuth
Copy link
Author

I didn't think so. Let me look. That would explain a lot.

@shawnwildermuth
Copy link
Author

So sorry for wasting your time. This was JSON Beatify extension that I thought I disabled. I mistakenly thought the icon here disabled, not just hid from the tool bar:

image

Totally a problem between the chair and the keyboard.

@captainbrosset
Copy link
Contributor

Thanks for checking and reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working more info needed We need more information before we can act on this issue
Projects
None yet
Development

No branches or pull requests

2 participants