Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Update Windows App SDK" in "Get started WinUI 3 (Win App SDK)" #3297

Merged
merged 12 commits into from
Nov 5, 2024
Merged

Add "Update Windows App SDK" in "Get started WinUI 3 (Win App SDK)" #3297

merged 12 commits into from
Nov 5, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Oct 30, 2024 •
edited
Loading

Rendered article section for review:

  • Get started with WebView2 in WinUI 3 (Windows App SDK) apps > Step 4: Update or install the Windows App SDK

Related PR in WebView2Samples repo: PR 257 (Replace WinUI3GetStarted 2020 project by result of latest project template)

AB#54470523

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Oct 30, 2024
sivMSFT
sivMSFT approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@sivMSFT sivMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - PM

mikehoffms
mikehoffms commented Nov 1, 2024
View reviewed changes
Copy link
Contributor Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Content Developer (Writer/Editor)

@mikehoffms mikehoffms changed the title Add section "Update Windows App SDK" in "Get started w wv2 in WinUI 3 (Windows App SDK) apps" Add "Update Windows App SDK" in "Get started in WinUI 3 (Windows App SDK)" Nov 1, 2024
@mikehoffms mikehoffms changed the title Add "Update Windows App SDK" in "Get started in WinUI 3 (Windows App SDK)" Add "Update Windows App SDK" in "Get started WinUI 3 (Windows App SDK)" Nov 1, 2024
@mikehoffms mikehoffms changed the title Add "Update Windows App SDK" in "Get started WinUI 3 (Windows App SDK)" Add "Update Windows App SDK" in "Get started WinUI 3 (Win App SDK)" Nov 1, 2024
@mikehoffms mikehoffms mentioned this pull request Nov 2, 2024
Merged
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit ee122cd:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/concepts/navigation-events.md ✅Succeeded View
microsoft-edge/webview2/get-started/get-started.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/blank-winui3-app.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/config-new-proj.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/create-project-winui3-desktop.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/enable-developer-mode.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/finished-app.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/getting-started-bing.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/getting-started-part-3.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/getting-started-script.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/webview2/get-started/winui-images/installer-winappsdk.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/new-winui3-project.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/nuget-install-winappsdk.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui-images/nuget-installed-tab.png ✅Succeeded View
microsoft-edge/webview2/get-started/winui.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 4419044 into main Nov 5, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/update-sdk branch November 5, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivMSFT sivMSFT sivMSFT approved these changes

Assignees
No one assigned
Labels
cat: webview2 WebView-related content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehoffms @sivMSFT @captainbrosset