Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timeout handling to make it honor error mode #104

Open
Michad opened this issue Jul 10, 2024 · 0 comments
Open

Improve timeout handling to make it honor error mode #104

Michad opened this issue Jul 10, 2024 · 0 comments

Comments

@Michad
Copy link
Owner

Michad commented Jul 10, 2024

Currently if you exceed the server timeout it's handled at a lower level than the normal error handling and it returns a static string with 503 status always.

At some level this isn't a huge problem because timeout happening is avoidable by using the client timeouts and solving bugs that might lead to a hang. But to have the expected error handling we should honor the error settings here like everything else. This might require implementing a custom timeout handler instead of using the std lib version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant