Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label translation #2

Open
Phocea opened this issue Sep 27, 2017 · 3 comments
Open

Label translation #2

Phocea opened this issue Sep 27, 2017 · 3 comments

Comments

@Phocea
Copy link

Phocea commented Sep 27, 2017

Hello,

Any news about the label translation which is currently not working?
I think you were waiting on some code change in aor?

Thanks
@MhdSyrwan
Copy link
Owner

Yes exactly.
They have not replied yet !

What you can do currently is to put labels manually.

@Phocea
Copy link
Author

Phocea commented Sep 29, 2017

ok..might be worth raising a new PR for this as the initial one may be a bit out of sight!

@MhdSyrwan
Copy link
Owner

MhdSyrwan commented Sep 29, 2017 •
edited
Loading

I will open a PR soon. but the problem is that some parts of the patch have no general meaning at all. They will be just written to make this library work ! They will not accept something like this.

That's why I wanted to see if we can find a more general thing to be added to core before opening the PR.

The part I'm talking about is the part that replaces any [number]. with .fields. like links[3].context => links.fields.context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Phocea @MhdSyrwan