From a24af45aaf0ab501881085afbf7bcfd9ff1ca2b6 Mon Sep 17 00:00:00 2001 From: Vitalij Vascenko Date: Wed, 28 Aug 2024 12:31:48 +0200 Subject: [PATCH] fix: [DX-2051] Fix OptimusTab title overflow --- optimus/lib/src/tabs.dart | 4 ++-- storybook/lib/stories/tab/tabs.dart | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/optimus/lib/src/tabs.dart b/optimus/lib/src/tabs.dart index f9abfe7f..da0134b1 100644 --- a/optimus/lib/src/tabs.dart +++ b/optimus/lib/src/tabs.dart @@ -36,7 +36,7 @@ class OptimusTab extends StatelessWidget { return Container( padding: EdgeInsets.symmetric(horizontal: tokens.spacing150), - height: 48, + height: tokens.sizing600, constraints: BoxConstraints(maxWidth: maxWidth ?? double.infinity), child: Row( mainAxisSize: MainAxisSize.min, @@ -46,7 +46,7 @@ class OptimusTab extends StatelessWidget { padding: EdgeInsets.only(right: tokens.spacing50), child: Icon(icon, size: tokens.sizing200), ), - Text(label, overflow: TextOverflow.ellipsis), + Flexible(child: Text(label, overflow: TextOverflow.ellipsis)), if (badge case final badge?) Padding( padding: EdgeInsets.only(left: tokens.spacing50), diff --git a/storybook/lib/stories/tab/tabs.dart b/storybook/lib/stories/tab/tabs.dart index 680d4dd3..31f54fd2 100644 --- a/storybook/lib/stories/tab/tabs.dart +++ b/storybook/lib/stories/tab/tabs.dart @@ -22,7 +22,7 @@ final Story tabsStory = Story( tabs: _items .map( (i) => OptimusTab( - label: 'Tab ${i + 1}', + label: i.isEven ? 'Tab with long name' : 'Tab ${i + 1}', icon: i.isOdd ? icon : null, badge: i.isOdd ? badge : null, maxWidth: _tabBarWidth / _items.length,