Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to read output #273

Open
1e4 opened this issue Aug 16, 2020 · 5 comments
Open

Hard to read output #273

1e4 opened this issue Aug 16, 2020 · 5 comments

Comments

@1e4
Copy link

1e4 commented Aug 16, 2020

The output given when using dark mode in Firefox for example is very very hard to read

image

Can the colors either be removed or can output support dark mode so it's more friendly to read?

Thanks, love the plugin

@Grawl
Copy link
Contributor

Grawl commented Sep 30, 2020

As a workaround, I just removed "color: #333333" in dist/vue-socketio.js

There is a PR to add darkMode option #231 but I think better to use window.matchMedia('(prefers-color-scheme: dark)').matches and style this for dark theme

@Grawl
Copy link
Contributor

Grawl commented Sep 30, 2020

#281

@Grawl
Copy link
Contributor

Grawl commented Sep 30, 2020

You can install my fork with yarn add 'Grawl/Vue-Socket.io#dark-theme-workaround'

@mcorning
Copy link

i use npm.
i ran your yarn command and now i cannot compile my project.
i tried yarn remove, but had to install yarn to be able to run remove.
and then i see this error:

$ yarn remove 'Grawl/Vue-Socket.io#dark-theme-workaround'
yarn remove v1.21.1
[1/2] Removing module Grawl/Vue-Socket.io#dark-theme-workaround...
error This module isn't specified in a package.json file.
info Visit https://yarnpkg.com/en/docs/cli/remove for documentation about this co
mmand.

and i still can't compile.

should i just reinstall vue-socket?

@mcorning
Copy link

odd. out of desperation, i closed all terminals and tried to compile again...and it worked. vue-socket debug is still dark, but given my option, i'll live with it until vue-socket fixes this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants