Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas integration tests are deactivated, activating them causes segfault #1017

Open
mroethlin opened this issue Aug 4, 2020 · 0 comments
Open
Labels
backend dawn related bug

Comments

@mroethlin
Copy link
Contributor

There seems to be a bug in the dawn/dawn/cmake/HasUnstructuredDeps.cmake cmake that disables building and testing of the unstructured integration tests. This line should read:

if (NOT HAS_UNSTRUCTURED_DEPS)

(omitting the DEFINED). This causes the unstructured integration tests to build and run again.

However, re-activating the tests leads to a segfault in the AtlasIntegrationTestCodeGenerate binary, but only on jenkins, and only in the release build. Unfortunately, I was not able to reproduce the problem so far.

@mroethlin mroethlin added backend dawn related bug labels Aug 4, 2020
mroethlin added a commit that referenced this issue Aug 4, 2020
## Technical Description

Introduces vertical (1D) & horizontal fields (2D) for unstructured situations. This required quite extensive changes throughout dawn.

* The horizontal field dimension in `sir::FieldDimensions` is now an optional.
* Vertical fields (1D) introduce a situation where we have a field with no location type. This affected all Validators, as well as the `PassLocalVarType`, which infers location types for local variables
* The unstructured codegens as well as de/serialization of `FieldDimensions` was adapted

## Testing

* New test covering the Validator Changes in `TestUnstructuredDimensionsCheckers`
* New test ensuring the correct working of the code generator in the unstructured integration tests, currently de-activated due to issue #1017
* New `dawn4py` test 

## Resolves / Enhances

Fixes #1013
@Stagno Stagno closed this as completed Oct 9, 2020
@Stagno Stagno reopened this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dawn related bug
Projects
None yet
Development

No branches or pull requests

2 participants