Conversation
…ationController:getBearerToken` call
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Member
Author
|
@SocketSecurity ignore npm/@metamask/snaps-controllers@19.0.0 This is ours, and seems to be a false positive. |
cryptodev-2s
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than providing a
getBearerTokenparameter to the constructor, the controller now directly callsAuthenticationController:getBearerToken.Note
Medium Risk
Breaking API change: authentication token retrieval moves from a constructor callback to a required messenger action, which can break consumers if allowlists aren’t updated. It also changes how Authorization headers are attached to outbound API calls, so misconfiguration could impact authenticated requests.
Overview
Removes the
getBearerTokenconstructor option and instead fetches bearer tokens by callingAuthenticationController:getBearerTokenvia the controller messenger for Transaction API and Sentinel requests.Updates the controller’s allowed action types/messenger delegation and adjusts tests to mock the new messenger action and assert Authorization header behavior. Dependency updates include bumping
@metamask/messengerto^1.1.0and adding@metamask/profile-sync-controller(plus lockfile/lavamoat adjustments), and the changelog documents the breaking migration steps.Written by Cursor Bugbot for commit 2195fdd. This will update automatically on new commits. Configure here.