Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta-Diagram default values to be implemented #33

Open
ddelpiano opened this issue Jul 18, 2022 · 0 comments
Open

Meta-Diagram default values to be implemented #33

ddelpiano opened this issue Jul 18, 2022 · 0 comments

Comments

@ddelpiano
Copy link
Member

ddelpiano commented Jul 18, 2022 •
edited
Loading

As per title, we need to ensure that the default are available for the library:

  • if the user does not specify a componentsMap ensure there is one available that uses the react-diagram default nodes and links.
  • if the user specify a type that does not exists in the components map, report the error in console but as a fallback use the default type for visualization.
  • exports portWidget from react-diagram, at the moment I am still importing this from the native library in the widget I am making.
@zsinnema zsinnema transferred this issue from MetaCell/PsyNeuLinkViewSource Jul 26, 2022
vidhya-metacell added a commit that referenced this issue Jul 29, 2022
@vidhya-metacell
#33 Remove style constants , create variables
ea63648
vidhya-metacell added a commit that referenced this issue Jul 29, 2022
@vidhya-metacell
#33 Remove styling from the nodes, add the varaint option
e037b2a
vidhya-metacell added a commit that referenced this issue Jul 29, 2022
@vidhya-metacell
#33 DRY fix
da023d4
vidhya-metacell added a commit that referenced this issue Jul 29, 2022
@vidhya-metacell
#33 Move the node color options to application theme
00aeb57
vidhya-metacell added a commit that referenced this issue Jul 29, 2022
@vidhya-metacell
#33 Resolve merge conflicts
48c32a6
vidhya-metacell added a commit that referenced this issue Jul 30, 2022
@vidhya-metacell
#33 Icons for nodes styles
9ba254b
vidhya-metacell added a commit that referenced this issue Aug 1, 2022
@vidhya-metacell
#33 Replace meta branch, add variant for node and link for meta node …
069d983 
…and meta link
zsinnema pushed a commit that referenced this issue Aug 1, 2022
@vidhya-metacell
#33 Remove styles and theme properties which are now cming from meta-…
914ff93 
…diagram
zsinnema pushed a commit that referenced this issue Aug 1, 2022
@vidhya-metacell
#33 Remove styles no more required here
3a797a7
@afonsobspinto afonsobspinto removed their assignment Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afonsobspinto @ddelpiano