fix date check in messages. #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the original branch had things this way and a merge messed it up. illustrates danger of long parallel branches. made indent for date checks only happen with the mtime field is in the message.
reidsunderland
approved these changes
Oct 18, 2024
Test Results249 tests 248 ✅ 1m 30s ⏱️ Results for commit cfe476a. ♻️ This comment has been updated with latest results. |
reidsunderland
approved these changes
Oct 18, 2024
|
Do we want this cherry-picked to go into 3.0.55post2 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1262 indent date check so it is entirely conditional on mtime field being present in message.