AM adaptation for U18.04 servers #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://docs.python.org/3/library/socket.html#socket.timeout socket.timeout has been replaced by TimeoutError. It's only been converted to an alias of TimeoutError since python3.10
Test Results1 tests 0 ✅ 14s ⏱️ For more details on these errors, see this check. Results for commit ba130dd. |
petersilva
approved these changes
Aug 13, 2024
petersilva
pushed a commit
that referenced
this pull request
Aug 16, 2024
See https://docs.python.org/3/library/socket.html#socket.timeout socket.timeout has been replaced by TimeoutError. It's only been converted to an alias of TimeoutError since python3.10 Co-authored-by: Reid Sunderland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.python.org/3/library/socket.html#socket.timeout
socket.timeoutis only an alias ofTimeoutErrorsince python3.10. So Ubuntu18.04 (python3.6) doesn't have this accomodation set in place.I commited from edcm-dirt18-1.. this is why @reidsunderland is set as the commiter. I was too lazy to change that so credit to Reid for the change 😄