Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror defaults to True despite documentation being misleading #1390

Open
andreleblanc11 opened this issue Feb 27, 2025 · 0 comments
Open

mirror defaults to True despite documentation being misleading #1390

andreleblanc11 opened this issue Feb 27, 2025 · 0 comments
Labels
Discussion_Needed developers should discuss this issue. Documentation Primary deliverable of this item is documentation Priority 3 - Important worrisome impact... should study carefully

Comments

@andreleblanc11
Copy link
Member

The mirror options' documentation states that it defaults to off.

We've discovered (the hard way) that this only seems to be true for a subscriber.
This is further emphasized in the documentation in this table where only the subscriber has mirror False in the Key Option Settings field.

The reason why this has been noticed recently is because v3.00.57 of sr3 has been added to operational servers. The change in #1337 has broken some of our configurations.

We had sarra/sender configs that had mirror False set after/reject statements in a configuration. So, because the masks' now get applied correctly and mirror defaults to True in sarra/senders, this caused unintended behaviours.

i.e.

...
directory /path/to/somewhere
accept .*something.*
mirror False                                      <- This used to get applied to all of the masks' in v3.00.56, but won't do anything in v3.00.57
...

Options

  • We could default mirror to False for all configs, but that would require an audit of all of our current sr3 configs and would likely be a lot of work.
  • We can update the documentation to reflect that mirror defaults to True, but defaults to False for a subscriber.
@andreleblanc11 andreleblanc11 added Discussion_Needed developers should discuss this issue. Documentation Primary deliverable of this item is documentation Priority 3 - Important worrisome impact... should study carefully labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion_Needed developers should discuss this issue. Documentation Primary deliverable of this item is documentation Priority 3 - Important worrisome impact... should study carefully
Projects
None yet
Development

No branches or pull requests

1 participant