Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnetlib deprecation breaks self tests. #1384

Open
petersilva opened this issue Feb 21, 2025 · 1 comment
Open

telnetlib deprecation breaks self tests. #1384

petersilva opened this issue Feb 21, 2025 · 1 comment
Labels
bitrot stuff broken because external dependency changes

Comments

@petersilva
Copy link
Contributor

when running pytest tests we get deprecation warnings:

sarracenia/flowcb/work/send_egc_les.py:32
  /home/peter/Sarracenia/sr3/sarracenia/flowcb/work/send_egc_les.py:32: DeprecationWarning: 'telnetlib' is deprecated and slated for removal in Python 3.13
    import logging, telnetlib, sys, os, stat, time

Presumably someone needs to re-write these tests with plain sockets... or research something else... because telnetlib is going away.

All we can do for now is disable the test.

@petersilva petersilva added the bitrot stuff broken because external dependency changes label Feb 21, 2025
@reidsunderland
Copy link
Member

I think we can delete that plugin. We're currently using the Sundew version and will eventually replace it with an sr3 feed using the SafetyNET II RESTful API: https://www.inmarsat.com/content/dam/inmarsat/corporate/documents/maritime/solutions-services/Inmarsat_ECG%20API%20Manual_V3.0.pdf.downloadasset.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitrot stuff broken because external dependency changes
Projects
None yet
Development

No branches or pull requests

2 participants