Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server flags are not yet set (or used) correctly. #5

Open
Merovius opened this issue Nov 19, 2018 · 0 comments
Open

Server flags are not yet set (or used) correctly. #5

Merovius opened this issue Nov 19, 2018 · 0 comments
Labels
beta Issues that should be fixed or closed as wontfix in v0

Comments

@Merovius
Copy link
Owner

The server should derive correct flags from the optional interfaces the Device supports (as well as the features we have implemented).

Relevant spec values:
@Merovius Merovius added the beta Issues that should be fixed or closed as wontfix in v0 label Nov 19, 2018
Merovius added a commit that referenced this issue Nov 20, 2018
@Merovius
always set FlagSendFlush in Loopback

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
9a63f02 
Device currently contains Sync() so we can rely on it being available.
Flush is important when using NBD in tests.

Updates #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta Issues that should be fixed or closed as wontfix in v0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Merovius