Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Better Door "Open" Property Support #255

Open
MerlinofMines opened this issue Aug 13, 2022 · 1 comment
Open

[Feature Request] Better Door "Open" Property Support #255

MerlinofMines opened this issue Aug 13, 2022 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation feature request New feature or request

Comments

@MerlinofMines
Copy link
Owner

Is your feature request related to a problem? Please describe.
Today if a door is open even a little, it is considered "open". This is annoying when working with doors since scripts like the following don't work:

open the "test door"
wait until the "test door" is open

Describe the solution you'd like
It might be better if "open" and "closed" were separate states, meaning both return false if the door is opening or closing. It also might be nice if there was a property representing the door's "State", i.e. is it open, opening, closed or closing?

The documentation for door handler could also be improved as it doesn't provide many examples or warn you of the above behavior.

Describe alternatives you've considered
The Door Ratio can be used to wait until a test door is fully open, though this isn't as intuitive.

Additional context
Today there's only one property for "Open", which is why "open" and "closed" must be mutually exclusive. The fix here is likely to separate those two properties. Thankfully only a couple block handlers (door, parachute) use the Open property, so seems doable. Perhaps we need a new property to represent "state" (or maybe "mode") to represent the door state?

@MerlinofMines MerlinofMines added documentation Improvements or additions to documentation feature request New feature or request labels Aug 13, 2022
@MerlinofMines MerlinofMines self-assigned this Aug 13, 2022
@CorwinMacGregor
Copy link
Contributor

door states: Opening, Open(ed), Closing, Closed
however, states Opening and Closing are not always proceeding towards Open or Closed (respectively).
if a door loses power (or is scripted to lose or not have power) while it is in states Opening or Closing, the animation locks, and the end-state is never advanced to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants