Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check that required arguments are set #8

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: check that required arguments are set #8

merged 1 commit into from
Sep 3, 2024

Conversation

DouglasBlackwood
Copy link
Contributor

Fixes MRGFY-3942

@DouglasBlackwood
fix: check that required arguments are set
956114e 
Fixes MRGFY-3942

Change-Id: I3394ee095ded814fce4ad872a1c1d134d3846a83
@mergify Mergify
Copy link

mergify bot commented Sep 3, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

Changelog requirements

  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

@mergify mergify bot requested a review from a team September 3, 2024 13:07
@mergify mergify bot requested a review from a team September 3, 2024 13:08
sileht
sileht approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@sileht sileht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do the same for Circle CI

@mergify mergify bot merged commit 6f216d9 into main Sep 3, 2024
6 checks passed
@mergify mergify bot added queued and removed queued labels Sep 3, 2024
@DouglasBlackwood
Copy link
Contributor Author

We should do the same for Circle CI

@sileht Mergifyio/circleci-ci-issues#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sileht sileht sileht approved these changes

@jd jd jd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DouglasBlackwood @jd @sileht