Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reap/Close old connections when max connection count is hit #9

Open
jbpratt opened this issue Nov 16, 2019 · 0 comments
Open

Reap/Close old connections when max connection count is hit #9

jbpratt opened this issue Nov 16, 2019 · 0 comments

Comments

@jbpratt
Copy link
Member

jbpratt commented Nov 16, 2019

Due to firefox tabs continually crashing on me, I quickly hit the 5 connection count cap (https://github.com/destinygg/chat/blob/master/connection.go#L138).

Rather than outright rejecting new connections, would it make sense to close old connections (resetting to 0) and allowing new connections?

I'd be perfectly willing to put in a patch/PR should anyone have any input on this.

ian@home ~ $ netstat | awk '/destiny/'
tcp        0      0 192.168.1.4:53654       destiny.gg:https        ESTABLISHED
tcp        0      0 192.168.1.4:54422       destiny.gg:https        ESTABLISHED
tcp        0      0 192.168.1.4:54232       destiny.gg:https        ESTABLISHED
tcp        0      0 192.168.1.4:54588       destiny.gg:https        ESTABLISHED
tcp        0      0 192.168.1.4:53466       destiny.gg:https        ESTABLISHED

I believe @SoMuchForSubtlety is having this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant