Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

git hf feature submit errors out if not using Github #87

Open
pgporada opened this issue Jul 27, 2015 · 8 comments
Open

git hf feature submit errors out if not using Github #87

pgporada opened this issue Jul 27, 2015 · 8 comments

Comments

@pgporada
Copy link

We're using Hubflow with Bitbucket being our DVCS. When trying to run the following command

git hf feature submit

we are returned

The remote repo for this branch, 'origin' is not a GitHub repository.

I believe this is due to the following lines.
https://github.com/mborsuk/hubflow/blob/develop/hubflow-common#L199-L206
https://github.com/mborsuk/hubflow/blob/develop/hubflow-common#L535-L541

Our process right now is to manually create feature pull request and submit them...

@stuartherbert
Copy link
Collaborator

Yeah. That's the only part of the Hubflow extension that actually knows about Github - it uses the Github API. I'm planning on removing this command unless there's a lot of users out there who rely on it.

@pgporada
Copy link
Author

Stuart,

My team of ~12 people are wanting to use the feature but with BitBucket instead of Github. Is it possible to have some sort of check to see if the origin is Github or BitBucket and have the feature submit act accordingly?

@stuartherbert
Copy link
Collaborator

I'll take a look and see. Give me a little bit of time to investigate; I am not a BitBucket user.

On 28 Jul 2015, at 16:06, Phil Porada [email protected] wrote:

Stuart,

My team of ~12 people are wanting to use the feature but with BitBucket instead of Github. Is it possible to have some sort of check to see if the origin is Github or BitBucket and have the feature submit act accordingly?


Reply to this email directly or view it on GitHub.

@EslamElHusseiny
Copy link

@stuartherbert @pgporada I've addressed bitbucket support for "git hf feature submit" command here #88

@bitwiseman
Copy link

@stuartherbert - my team uses the automatic pull request creation. Can you make the check optional, so people can turn it off if they're not using github?

@EslamElHusseiny
Copy link

@bitwiseman what kind of git servers you're using rather than github and bitbucket ?

@ladyrassilon
Copy link

I have to say, creation of pull requests by command line are a really nice feature...

@tommynsong
Copy link

+1 for optional
we are using Github Enterprise

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants