You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.
The help string for hf update only mentions pulling changes from remote to local, so we did not expect a developer's local master to get pushed to origin. Although it was a mistake that originally led the developer to having changes in their master branch, it still should not have made it back to origin as a result of hf update - in our opinion, changes to master (as well as to develop) should always be an explicit action, not a side effect of something else.
The text was updated successfully, but these errors were encountered:
hf update is meant to bring the local master and develop branches into sync with origin. The original thinking here was that Hubflow exists to implement a star topology on top of git, partly because I'm not confident that it is easy for someone to notice that local and origin are out of sync.
I'll take a look at how easy it would be to avoid pushing back up to origin.
@cantonic We'd like to pick up gitflow again and this is one of the blockers. But one thing that might help you in the meantime would be to enable branch protection on master in GitHub.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This was extremely surprising behavior for us: https://github.com/datasift/gitflow/blob/master/hubflow-common#L369-L387
The help string for
hf update
only mentions pulling changes from remote to local, so we did not expect a developer's local master to get pushed to origin. Although it was a mistake that originally led the developer to having changes in their master branch, it still should not have made it back to origin as a result ofhf update
- in our opinion, changes to master (as well as to develop) should always be an explicit action, not a side effect of something else.The text was updated successfully, but these errors were encountered: