-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Issues Due to SDK #192
Comments
Wow that's a lot 😬. Thanks for diving in @pnadolny13! |
Eeek nice issue @pnadolny13 . 30s per table is high, how many columns is it? I'd guess over 50-100? If it's the number of columns the cache issue would fix it but I think just optimizing our prepare table function would do it too, I think there's a meta data call per column (I'm guessing as I haven't dove in but I know the reserved column name test takes a while to run and it has a ton of columns) |
I published version |
@edgarrmondragon it looks like theres a release out with part of this but meltano/sdk#1779 is still pending. I actually think that one is whats causing the 30s per table lag since its constantly running the same metadata query. Would you mind reviewing that? |
Closed by meltano/sdk#1779 and #208 |
This issue should be closed by meltano/sdk#1779 and meltano/sdk#1962 in the SDK so its mostly a reminder to bump the version once those fixes are released.
I was using this target and noticed a few performance issues similar to those I'd seen in target-snowflake:
cc @visch @edgarrmondragon
The text was updated successfully, but these errors were encountered: